Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak shutdown sequence #3094

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Tweak shutdown sequence #3094

merged 2 commits into from
Apr 23, 2021

Conversation

pkedy
Copy link
Member

@pkedy pkedy commented Apr 23, 2021

Description

Continuation of #3088. This PR changes the shutdown sequence to:

  • stop actor
  • delay
  • close components
  • exit

Issue reference

Resolves #dapr/components-contrib#779

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #3094 (bb7da38) into master (4efc428) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   58.99%   58.97%   -0.02%     
==========================================
  Files          84       84              
  Lines        7694     7696       +2     
==========================================
  Hits         4539     4539              
- Misses       2842     2844       +2     
  Partials      313      313              
Impacted Files Coverage Δ
pkg/runtime/runtime.go 51.67% <20.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efc428...bb7da38. Read the comment docs.

@pkedy
Copy link
Member Author

pkedy commented Apr 23, 2021

/cc @artursouza @mukundansundar @yaron2

The covecov errors are because I changed the body of ShutdownWithWait and it is not covered by a test (it calls os.Exit).

@artursouza artursouza merged commit 82501d4 into dapr:master Apr 23, 2021
@pkedy pkedy deleted the shutdown_sequence branch April 23, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants