New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc proxying to enable bring-your-own-proto #3277
Conversation
Could you share more about why choose this grpc proxy and what changes have made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please, address the comments above.
Codecov Report
@@ Coverage Diff @@
## master #3277 +/- ##
==========================================
- Coverage 59.36% 59.28% -0.08%
==========================================
Files 87 91 +4
Lines 7806 7973 +167
==========================================
+ Hits 4634 4727 +93
- Misses 2855 2919 +64
- Partials 317 327 +10
Continue to review full report at Codecov.
|
I chose this library as it's complete functionality wise, very well tested, and has no dependencies other than Go stdlib and grpc libraries. |
Ok, I'll now move into the second phase which is E2E and the porting of the proxy library. |
Proxy porting is done. |
Closes #3231.
Closes #3096.
Closes #3065.
This PR enables users to work with their existing gRPC protos for service invocation, while still utilizing Dapr's service invocation features like mTLS, API auth, telemetry, access lists etc.
Notes for the reviewer
High level changes made in this PR
pkg/configuration
topkg/acl
. This is for the better and ACLs now live in a dedicated and reusable package.grpc_diagnostics.go
to support users with gRPC streams.Two phase review
In order to keep the list of files changed small for the actual code change, I'm waiting with adding the e2e tests. Once the initial review is done, the following will be added: