Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing yaml tag for mtls spec config #3864

Merged
merged 2 commits into from Nov 10, 2021

Conversation

zcong1993
Copy link
Contributor

@zcong1993 zcong1993 commented Nov 8, 2021

Description

Add missing yaml tag for mtls spec config which might be used as sentry Self-hosted config. And this example in document https://docs.dapr.io/operations/security/mtls/#sentry-configuration-1 not works for now before fix.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@zcong1993 zcong1993 requested review from a team as code owners November 8, 2021 08:51
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #3864 (841ba9f) into master (c78a815) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3864   +/-   ##
=======================================
  Coverage   62.46%   62.46%           
=======================================
  Files         101      101           
  Lines        9525     9525           
=======================================
  Hits         5950     5950           
  Misses       3109     3109           
  Partials      466      466           
Impacted Files Coverage Δ
pkg/config/configuration.go 71.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78a815...841ba9f. Read the comment docs.

Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artursouza artursouza added this to the v1.6 milestone Nov 10, 2021
@artursouza artursouza merged commit e6e2729 into dapr:master Nov 10, 2021
@zcong1993 zcong1993 deleted the mtls-config branch November 10, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants