Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add scopes to subscription conversion #3919

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

pkedy
Copy link
Member

@pkedy pkedy commented Nov 18, 2021

Description

This PR adds converting subscription scopes between v1alpha1 and v2alpha1.

Issue reference

Closes #3914

Checklist

@pkedy pkedy requested review from a team as code owners November 18, 2021 15:05
@pkedy pkedy changed the base branch from master to release-1.5 November 18, 2021 15:05
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #3919 (5bfe5a6) into release-1.5 (801df5d) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.5    #3919      +/-   ##
===============================================
- Coverage        62.46%   62.40%   -0.07%     
===============================================
  Files              101      101              
  Lines             9525     9503      -22     
===============================================
- Hits              5950     5930      -20     
+ Misses            3109     3108       -1     
+ Partials           466      465       -1     
Impacted Files Coverage Δ
pkg/messaging/grpc_proxy.go 100.00% <0.00%> (+7.14%) ⬆️
utils/utils.go 46.34% <0.00%> (+7.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 801df5d...5bfe5a6. Read the comment docs.

@pkedy
Copy link
Member Author

pkedy commented Nov 18, 2021

/ok-to-test

@dapr-bot
Copy link
Collaborator

Found the available test cluster - dapr-aks-e2e-08 for linux. Please check the build status.

@dapr-bot
Copy link
Collaborator

Found the available test cluster - dapr-aks-e2e-05 for windows. Please check the build status.

@artursouza artursouza modified the milestone: v1.5 Nov 18, 2021
@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@artursouza artursouza added this to the v1.5 milestone Nov 18, 2021
@artursouza artursouza merged commit 05d8311 into dapr:release-1.5 Nov 18, 2021
@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@pkedy pkedy deleted the subscription_convert_scopes_3914 branch November 18, 2021 17:23
@berndverst berndverst mentioned this pull request Nov 24, 2021
11 tasks
berndverst pushed a commit to berndverst/dapr that referenced this pull request Nov 29, 2021
yaron2 added a commit that referenced this pull request Nov 30, 2021
Cherry-pick into master: Added copying of scopes when converting subscriptions (#3919)
x-shadow-man pushed a commit to x-shadow-man/dapr that referenced this pull request Jan 4, 2022
Signed-off-by: x-shadow-man <1494445739@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription v1alpha1 is not transformed in v2alpha1 correctly (scopes field is missing)
3 participants