Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #3892 from 1046102779/horus/websocket #3959

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

artursouza
Copy link
Member

upgrade/websocket: v1.8.6 exist horus

Description

Issue reference

Please reference the issue this PR will close: #3892

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

upgrade/websocket: v1.8.6 exist horus
@artursouza artursouza requested review from a team as code owners November 29, 2021 07:28
@artursouza artursouza mentioned this pull request Nov 29, 2021
11 tasks
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #3959 (b80f154) into release-1.5 (05d8311) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.5    #3959      +/-   ##
===============================================
+ Coverage        62.37%   62.38%   +0.01%     
===============================================
  Files              101      101              
  Lines             9498     9498              
===============================================
+ Hits              5924     5925       +1     
+ Misses            3109     3108       -1     
  Partials           465      465              
Impacted Files Coverage Δ
pkg/http/server.go 64.62% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d8311...b80f154. Read the comment docs.

Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaron2 yaron2 merged commit c6ad3f3 into dapr:release-1.5 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants