New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts - Supports to customize livenessProbe and readinessProbe #4049
Conversation
Instead of changing the defaults globally in Dapr, isn't it better to use the already configurable settings to increase the delay for your Argo deployment? |
Maybe we should accept the custom params when |
That's a much better idea. |
Increase the dapr-operator and dapr-placement delay seconds Signed-off-by: Hao Xin <haoxinst@gmail.com> WIP
PR updated~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #4049 +/- ##
=======================================
Coverage 63.41% 63.41%
=======================================
Files 101 101
Lines 9567 9567
=======================================
Hits 6067 6067
Misses 3026 3026
Partials 474 474 Continue to review full report at Codecov.
|
Description
When I use Argo CD to deploy the Dapr, some components (Operator and Placement) need more time to start.
Sometimes the Argo CD may kill/restart the pods because of the health check.
So I think it's a easy and safe way to increase the initial delay and period seconds
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: