Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed create timer duetime #4075

Merged
merged 1 commit into from Jan 3, 2022
Merged

Fixed create timer duetime #4075

merged 1 commit into from Jan 3, 2022

Conversation

ls-2018
Copy link
Member

@ls-2018 ls-2018 commented Jan 1, 2022

Description

If the timer is created at a previous time, we should not create it.
e.g. dueTime: "-0h0m0s"

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: ls-2018 <liushuo@vackbot.com>
@ls-2018 ls-2018 requested review from a team as code owners January 1, 2022 00:42
Copy link
Contributor

@tanvigour tanvigour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #4075 (0c070e1) into master (ef508ba) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
- Coverage   63.41%   63.39%   -0.03%     
==========================================
  Files         101      101              
  Lines        9579     9581       +2     
==========================================
- Hits         6075     6074       -1     
- Misses       3031     3033       +2     
- Partials      473      474       +1     
Impacted Files Coverage Δ
pkg/actors/actors.go 66.84% <0.00%> (-0.15%) ⬇️
pkg/grpc/server.go 34.61% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef508ba...0c070e1. Read the comment docs.

@yaron2 yaron2 merged commit f2d77e7 into dapr:master Jan 3, 2022
@yaron2 yaron2 added this to the v1.6 milestone Jan 3, 2022
@yaron2
Copy link
Member

yaron2 commented Jan 3, 2022

Thanks for your contribution @ls-2018 and welcome to the Dapr community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants