Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flag to enable/disable kubernetes builtin secret store #4605

Merged
merged 8 commits into from Jun 1, 2022

Conversation

DeepanshuA
Copy link
Contributor

@DeepanshuA DeepanshuA commented May 11, 2022

Description

Currently, builtin kubernetes secret store is being called by default every time dapr runtime starts.
Adding enable-builtin-k8s-secret-store flag so that a user can disable calling it.
By default, behavior will remain same and if not specified, its value will be true by default.

Issue reference

Please reference the issue this PR will close: #4227

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@DeepanshuA DeepanshuA requested review from a team as code owners May 11, 2022 08:30
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #4605 (417a122) into master (8fa235d) will decrease coverage by 0.17%.
The diff coverage is 89.47%.

❗ Current head 417a122 differs from pull request most recent head 10f42f4. Consider uploading reports for the commit 10f42f4 to get more accurate results

@@            Coverage Diff             @@
##           master    #4605      +/-   ##
==========================================
- Coverage   65.67%   65.49%   -0.18%     
==========================================
  Files         111      111              
  Lines       11422    11391      -31     
==========================================
- Hits         7501     7461      -40     
- Misses       3376     3386      +10     
+ Partials      545      544       -1     
Impacted Files Coverage Δ
pkg/runtime/cli.go 2.18% <0.00%> (-0.02%) ⬇️
pkg/injector/pod_patch.go 91.05% <100.00%> (+0.06%) ⬆️
pkg/runtime/config.go 100.00% <100.00%> (ø)
pkg/runtime/runtime.go 67.66% <100.00%> (-0.88%) ⬇️
pkg/grpc/grpc.go 48.27% <0.00%> (-14.38%) ⬇️
pkg/runtime/options.go 10.00% <0.00%> (-10.00%) ⬇️
pkg/grpc/proxy/handler.go 69.66% <0.00%> (-0.34%) ⬇️
pkg/components/state/state_config.go 100.00% <0.00%> (ø)
pkg/actors/actors.go 66.32% <0.00%> (+0.12%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa235d...10f42f4. Read the comment docs.

@DeepanshuA DeepanshuA changed the title [WIP] Enable flag to enable/disable kubernetes builtin secret store Enable flag to enable/disable kubernetes builtin secret store May 12, 2022
pkg/runtime/cli.go Outdated Show resolved Hide resolved
pkg/runtime/runtime.go Show resolved Hide resolved
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA DeepanshuA force-pushed the enable_builtin-k8s_secret_store branch from ac07b2a to 56a3731 Compare May 25, 2022 15:24
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza added this to the v1.8 milestone Jun 1, 2022
@artursouza artursouza merged commit f31c523 into dapr:master Jun 1, 2022
ItalyPaleAle pushed a commit to ItalyPaleAle/dapr that referenced this pull request Jun 8, 2022
)

* Adding flag to enable/disable kubernetes builtIn secret store

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

* remove unwanted logging

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

* Add unit test for disable

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

* Disable/Enable K8s Secret Store

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

* Add E2E test for disable flag

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

* Remove unwanted dir from dapr_tests

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

* Remove unwanted blank line

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Service Account Tokens to Bound Tokens
4 participants