New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable flag to enable/disable kubernetes builtin secret store #4605
Enable flag to enable/disable kubernetes builtin secret store #4605
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4605 +/- ##
==========================================
- Coverage 65.67% 65.49% -0.18%
==========================================
Files 111 111
Lines 11422 11391 -31
==========================================
- Hits 7501 7461 -40
- Misses 3376 3386 +10
+ Partials 545 544 -1
Continue to review full report at Codecov.
|
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
ac07b2a
to
56a3731
Compare
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) * Adding flag to enable/disable kubernetes builtIn secret store Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * remove unwanted logging Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Add unit test for disable Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Disable/Enable K8s Secret Store Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Add E2E test for disable flag Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Remove unwanted dir from dapr_tests Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> * Remove unwanted blank line Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Description
Currently, builtin kubernetes secret store is being called by default every time dapr runtime starts.
Adding enable-builtin-k8s-secret-store flag so that a user can disable calling it.
By default, behavior will remain same and if not specified, its value will be true by default.
Issue reference
Please reference the issue this PR will close: #4227
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: