Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-build/push and helm install targets to makefile #493

Merged
merged 9 commits into from Sep 30, 2019
Merged

Add docker-build/push and helm install targets to makefile #493

merged 9 commits into from Sep 30, 2019

Conversation

youngbupark
Copy link
Contributor

@youngbupark youngbupark commented Sep 30, 2019

Description

This PR simplify the docker image build/push to the docker registry via make. With this change, contributor can easily build docker image and push it to their private registry via make command.

Set the environment variable to set your private docker registry and tag

# example
export ACTIONS_REGISTRY=docker.io/youngp
export ACTIONS_TAG=dev
  • Docker image build
make docker-build
# make DEBUG=1 docker-build   for debuggable binaries
  • Docker image push
make docker-push
  • Deploy from helm chart with the latest change

#492 needs to be done to make docker-deploy-k8s work.

make docker-deploy-k8s

Issue reference

#490
#469

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests - N/A
  • Unit tests passing - N/A
  • End-to-end tests passing
  • Extended the documentation - Working in the separate pr
  • Specification has been updated - N/A
  • Provided sample for the feature - N/A

yaron2
yaron2 previously approved these changes Sep 30, 2019
Makefile Outdated Show resolved Hide resolved
@LMWF LMWF self-requested a review September 30, 2019 23:50
@youngbupark youngbupark merged commit a3bd10f into dapr:master Sep 30, 2019
@youngbupark youngbupark deleted the youngp/add-docker-build branch September 30, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants