New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case-insensitive parsing of metadata properties actorStateStore
and keyPrefix
#6206
Conversation
… `keyPrefix` Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #6206 +/- ##
==========================================
+ Coverage 64.12% 64.13% +0.01%
==========================================
Files 185 185
Lines 17945 17957 +12
==========================================
+ Hits 11507 11517 +10
- Misses 5530 5531 +1
- Partials 908 909 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nitpick comments.
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ae23a9b
@ItalyPaleAle docs need to be added for this. |
In components-contrib, we've been making some efforts to make all component metadata parsing case-insensitive (thanks especially to @berndverst ) and use
utils.IsTruthy
to parse booleans.The runtime itself parses the component metadata to extract certain fields, including:
actorStateStore
(state stores) andkeyPrefix
(state stores and locks).This PR changes matching for
actorStateStore
andkeyPrefix
to be case-insensitive. Additionally, it usesutils.IsTruthy
to convertactorStateStore
to a boolean (so it's case-insensitive too and values like "1" map to true).