Fix the connection leak problem of app callback gRPC client #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaofeihang <gaofeihang@gmail.com>
artursouza
approved these changes
Apr 21, 2023
|
/ok-to-test |
2 similar comments
|
/ok-to-test |
|
/ok-to-test |
Dapr E2E testCommit ref: 9a2c82b ✅ Build succeeded for linux/amd64
✅ Build succeeded for linux/arm64
✅ Infrastructure deployed
|
Dapr E2E testCommit ref: 9a2c82b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for linux/arm64
✅ Build succeeded for windows/amd64
|
Dapr E2E testCommit ref: 9a2c82b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
✅ Build succeeded for linux/arm64
|
ItalyPaleAle
approved these changes
Apr 21, 2023
|
/ok-to-test |
Dapr E2E testCommit ref: 9a2c82b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for linux/arm64
✅ Build succeeded for windows/amd64
|
|
/ok-to-test |
1 similar comment
|
/ok-to-test |
Dapr E2E testCommit ref: 3860898 ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for linux/arm64
✅ Build succeeded for windows/amd64
|
Dapr E2E testCommit ref: 3860898 ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for linux/arm64
✅ Build succeeded for windows/amd64
|
Codecov Report
@@ Coverage Diff @@
## master #6274 +/- ##
==========================================
- Coverage 64.45% 64.44% -0.02%
==========================================
Files 189 189
Lines 18885 18891 +6
==========================================
+ Hits 12173 12174 +1
- Misses 5744 5751 +7
+ Partials 968 966 -2
|
berndverst
approved these changes
Apr 27, 2023
|
/ok-to-perf |
1 similar comment
|
/ok-to-perf |
Dapr perf testCommit ref: b001582 ✅ Infrastructure deployed
✅ Build succeeded
❌ Perf tests failedPlease check the logs for details on the error. |
Dapr perf testCommit ref: 46bcf53 ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
|
related to #6301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
Fix #6273
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: