New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement nil check for CEL program in matchRoutingRule #6280
Merged
yaron2
merged 6 commits into
dapr:master
from
dmutterSF:subscription-rule-match-program-nil-check
May 3, 2023
Merged
fix: implement nil check for CEL program in matchRoutingRule #6280
yaron2
merged 6 commits into
dapr:master
from
dmutterSF:subscription-rule-match-program-nil-check
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 65 in 1ae5816
|
dmutterSF
force-pushed
the
subscription-rule-match-program-nil-check
branch
3 times, most recently
from
April 25, 2023 15:33
6d107b4
to
1ffab39
Compare
Signed-off-by: dmutter <dmutter@starface.com>
Signed-off-by: dmutter <dmutter@starface.com>
dmutterSF
force-pushed
the
subscription-rule-match-program-nil-check
branch
from
April 26, 2023 07:33
1ffab39
to
d8b3eb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #6280 +/- ##
==========================================
- Coverage 64.40% 64.39% -0.01%
==========================================
Files 189 189
Lines 18881 18885 +4
==========================================
+ Hits 12160 12161 +1
- Misses 5753 5759 +6
+ Partials 968 965 -3
|
Closed
Signed-off-by: yaron2 <schneider.yaron@live.com>
yaron2
approved these changes
May 3, 2023
Thanks for your contribution @dmutterSF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid nil pointer dereference when evaluating expression.
Resolves #6036
Haven't written go before so this might not be the proper or most optimal solution