Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadletter poison message explicitly #6282

Closed
march425 opened this issue Apr 24, 2023 · 3 comments · Fixed by #7097
Closed

deadletter poison message explicitly #6282

march425 opened this issue Apr 24, 2023 · 3 comments · Fixed by #7097
Assignees
Labels
Milestone

Comments

@march425
Copy link

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Describe the feature

Dapr pubsub does not provide a way to deadletter a poison message explicitly. AFAIK, the only way to deadletter poison messages today is to let the retry policy be exhausted until the message lands in the DLQ. Obviously this consumes resources unnecessarily. Dealing with poison messages efficiently is an integral part of a scalable message consumer.

The current contract needs to be revisited. Currently there's no difference in behavior between SUCCESS and DROP. They both consider the message handled and it's removed from the Q.
Either make DROP dead-letter immediately or add a new response for DEADLETTER.

Release Note

RELEASE NOTE:

@artursouza
Copy link
Member

artursouza commented Apr 25, 2023

I agree to make DROP move message to deadletter. Creating a new response type when SUCCESS and DROP have same behavior would be confusing IMO. So, for customers that don't want a message to be processed ever, SUCCESS is still there.

@artursouza
Copy link
Member

As part of this work, adding E2E test is important to make sure this change in behavior remains in future versions.

@artursouza artursouza added this to the v1.12 milestone Apr 25, 2023
@artursouza artursouza added P1 size/S 1 week of work good first issue Good for newcomers labels Apr 25, 2023
@Taction
Copy link
Member

Taction commented Apr 27, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants