Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send dropped message to dead-letter if configured #7097

Merged
merged 2 commits into from Oct 27, 2023

Conversation

Taction
Copy link
Member

@Taction Taction commented Oct 25, 2023

Description

Send dropped pubsub messages to deadletter if configured.

Issue reference

Please reference the issue this PR will close: #6282

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction
Copy link
Member Author

Taction commented Oct 25, 2023

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 25, 2023

Dapr E2E test

🔗 Link to Action run

Commit ref: 6738c01

✅ Build succeeded for linux/amd64

  • Image tag: dapre2ec8347e445el
  • Test image tag: dapre2ec8347e445el

✅ Infrastructure deployed

Cluster Resource group name Azure region
Linux Dapr-E2E-dapre2ec8347e445el westus3
Windows Dapr-E2E-dapre2ec8347e445ew westus3
Linux/arm64 Dapr-E2E-dapre2ec8347e445ela eastus

✅ Build succeeded for windows/amd64

  • Image tag: dapre2ec8347e445ew
  • Test image tag: dapre2ec8347e445ew

✅ Tests succeeded on windows/amd64

  • Image tag: dapre2ec8347e445ew
  • Test image tag: dapre2ec8347e445ew

✅ Tests succeeded on linux/amd64

  • Image tag: dapre2ec8347e445el
  • Test image tag: dapre2ec8347e445el

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (50a3dfd) 65.16% compared to head (5a06f50) 65.11%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7097      +/-   ##
==========================================
- Coverage   65.16%   65.11%   -0.05%     
==========================================
  Files         230      231       +1     
  Lines       21005    21032      +27     
==========================================
+ Hits        13687    13695       +8     
- Misses       6185     6204      +19     
  Partials     1133     1133              
Files Coverage Δ
pkg/runtime/processor/pubsub/bulksub_resiliency.go 96.29% <100.00%> (ø)
pkg/runtime/processor/pubsub/publish.go 78.07% <100.00%> (ø)
pkg/runtime/pubsub/errors.go 0.00% <ø> (ø)
utils/utils.go 80.00% <60.00%> (+16.36%) ⬆️
pkg/runtime/processor/pubsub/topics.go 55.21% <0.00%> (-2.12%) ⬇️
pkg/runtime/processor/pubsub/bulk_subscriber.go 64.43% <0.00%> (-2.24%) ⬇️
utils/kubernetes.go 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Taction Taction marked this pull request as ready for review October 25, 2023 08:48
@Taction Taction requested review from a team as code owners October 25, 2023 08:48
Signed-off-by: Yaron Schneider <schneider.yaron@live.com>
@yaron2 yaron2 merged commit 3ba1cdc into dapr:master Oct 27, 2023
20 of 22 checks passed
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deadletter poison message explicitly
4 participants