Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Allow configuring HA mode for placement separately from global.ha.enabled #6518

Merged
merged 2 commits into from Jun 16, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

For all control plane services except Placement, it's possible to set a replicaCount (for example, dapr_operator.replicaCount) regardless of whether HA mode is enabled for the control plane (global.ha.enabled).

Placement is the only service where insofar it's not possible to enable HA mode without setting global.ha.enabled. This is a problem because it doesn't allow controlling the number of replicas for each control plane service.

This PR adds the option dapr_placement.ha which if set to true, makes Placement deployed in HA mode (with exactly 3 replicas), even if global.ha.enabled is false.

….ha.enabled`

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle requested review from a team as code owners June 14, 2023 21:08
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #6518 (a2526b0) into master (8a995de) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head a2526b0 differs from pull request most recent head 367bbe9. Consider uploading reports for the commit 367bbe9 to get more accurate results

@@            Coverage Diff             @@
##           master    #6518      +/-   ##
==========================================
- Coverage   65.84%   65.76%   -0.09%     
==========================================
  Files         198      197       -1     
  Lines       19168    19119      -49     
==========================================
- Hits        12621    12573      -48     
+ Misses       5533     5530       -3     
- Partials     1014     1016       +2     

see 8 files with indirect coverage changes

@yaron2 yaron2 merged commit 041c100 into dapr:master Jun 16, 2023
7 of 9 checks passed
@ItalyPaleAle ItalyPaleAle added this to the v1.12 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants