-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed goroutine leak in reminders and timers #6523
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
00a4563
Fixed goroutine leak in reminders and timers
ItalyPaleAle 64c82be
Merge branch 'master' into timers-goroutine-leak
ItalyPaleAle 184ece8
Merge branch 'master' into timers-goroutine-leak
ItalyPaleAle 183f17b
Merge branch 'master' into timers-goroutine-leak
ItalyPaleAle f5b2a71
Added unit tests + some more tweaks
ItalyPaleAle f10110d
Fixed last goroutine leaks
ItalyPaleAle 9b6855f
Merge branch 'master' into timers-goroutine-leak
artursouza 8bb0288
Comments
ItalyPaleAle 0d84a67
Merge branch 'timers-goroutine-leak' of https://github.com/ItalyPaleA…
ItalyPaleAle f2c1a7a
Merge branch 'master' into timers-goroutine-leak
dapr-bot fc0e9ab
Merge branch 'master' into timers-goroutine-leak
dapr-bot ac8dbf2
Merge branch 'master' into timers-goroutine-leak
dapr-bot 4b4ac3d
Merge branch 'master' into timers-goroutine-leak
dapr-bot File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewers: this was deleted because when we hit this stage, the reminder has already fired. Trying to drain it again would cause a deadlock.