New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dapr runtime version and enabled features to Metadata API #6537
Merged
yaron2
merged 18 commits into
dapr:master
from
shubham1172:shubham1172/update-metadata-api-runtime-version
Jun 19, 2023
Merged
Add Dapr runtime version and enabled features to Metadata API #6537
yaron2
merged 18 commits into
dapr:master
from
shubham1172:shubham1172/update-metadata-api-runtime-version
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #6537 +/- ##
==========================================
+ Coverage 65.77% 65.83% +0.05%
==========================================
Files 198 199 +1
Lines 19211 19224 +13
==========================================
+ Hits 12636 12656 +20
- Misses 5557 5559 +2
+ Partials 1018 1009 -9
|
ItalyPaleAle
requested changes
Jun 17, 2023
ItalyPaleAle
previously approved these changes
Jun 17, 2023
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
daixiang0
previously approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-features Add "enabledFeatures" to GetMetadata response
shubham1172
changed the title
Add Dapr runtime version to Metadata API root
Add Dapr runtime version and enabled features to Metadata API
Jun 19, 2023
ItalyPaleAle
previously approved these changes
Jun 19, 2023
daixiang0
previously approved these changes
Jun 19, 2023
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
…le/dapr into shubham1172/update-metadata-api-runtime-version
7 tasks
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
previously approved these changes
Jun 19, 2023
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
ItalyPaleAle
approved these changes
Jun 19, 2023
yaron2
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-authored-by: @ItalyPaleAle
Add a runtime version to metadata root. It is kept in extended metadata for back-compat but should be deprecated later.
This also adds an 'enabledFeatures' key with list of preview features enabled.
Issue reference
Please reference the issue this PR will close: #6528
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: