Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dapr runtime version and enabled features to Metadata API #6537

Merged

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Jun 17, 2023

Description

Co-authored-by: @ItalyPaleAle

Add a runtime version to metadata root. It is kept in extended metadata for back-compat but should be deprecated later.
This also adds an 'enabledFeatures' key with list of preview features enabled.

daprd --app-id test --app-port 3001 --app-protocol grpc --dapr-http-port 3501 -- sleep 1000
curl localhost:3501/v1.0/metadata | jq .
{
  "id": "test",
  "runtimeVersion": "edge",
  "enabledFeatures": [
    "ServiceInvocationStreaming"
  ],
  "extended": {
    "daprRuntimeVersion": "edge"
  },
  "appConnectionProperties": {
    "port": 3001,
    "protocol": "grpc",
    "channelAddress": "127.0.0.1"
  },
}

Issue reference

Please reference the issue this PR will close: #6528

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

ItalyPaleAle and others added 7 commits June 15, 2023 15:58
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 marked this pull request as ready for review June 17, 2023 05:39
@shubham1172 shubham1172 requested review from a team as code owners June 17, 2023 05:39
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #6537 (a584a2b) into master (959eac3) will increase coverage by 0.05%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #6537      +/-   ##
==========================================
+ Coverage   65.77%   65.83%   +0.05%     
==========================================
  Files         198      199       +1     
  Lines       19211    19224      +13     
==========================================
+ Hits        12636    12656      +20     
- Misses       5557     5559       +2     
+ Partials     1018     1009       -9     
Impacted Files Coverage Δ
pkg/http/api.go 79.70% <0.00%> (-0.06%) ⬇️
pkg/grpc/api.go 74.35% <100.00%> (+0.03%) ⬆️
pkg/grpc/universalapi/api_metadata.go 95.52% <100.00%> (+0.13%) ⬆️
pkg/http/api_metadata.go 100.00% <100.00%> (ø)
pkg/runtime/runtime.go 64.79% <100.00%> (+0.13%) ⬆️

... and 5 files with indirect coverage changes

pkg/grpc/api_test.go Show resolved Hide resolved
ItalyPaleAle
ItalyPaleAle previously approved these changes Jun 17, 2023
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
daixiang0
daixiang0 previously approved these changes Jun 19, 2023
Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-features

Add "enabledFeatures" to GetMetadata response
@shubham1172 shubham1172 dismissed stale reviews from daixiang0 and ItalyPaleAle via 2541a82 June 19, 2023 03:20
@shubham1172 shubham1172 changed the title Add Dapr runtime version to Metadata API root Add Dapr runtime version and enabled features to Metadata API Jun 19, 2023
ItalyPaleAle
ItalyPaleAle previously approved these changes Jun 19, 2023
daixiang0
daixiang0 previously approved these changes Jun 19, 2023
@shubham1172 shubham1172 marked this pull request as draft June 19, 2023 06:15
…le/dapr into shubham1172/update-metadata-api-runtime-version
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle dismissed stale reviews from daixiang0 and themself via ef28d9c June 19, 2023 06:40
@shubham1172 shubham1172 marked this pull request as ready for review June 19, 2023 06:40
ItalyPaleAle
ItalyPaleAle previously approved these changes Jun 19, 2023
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@yaron2 yaron2 merged commit bd164b1 into dapr:master Jun 19, 2023
30 of 31 checks passed
@ItalyPaleAle ItalyPaleAle added this to the v1.12 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dapr runtime version to Metadata API root
5 participants