Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Cherry-pick: Fixed goroutine leak in reminders and timers (#6523) #6553

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

Cherry-picks #6523 into release-1.11

* Fixed goroutine leak in reminders and timers

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Added unit tests + some more tweaks

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed last goroutine leaks

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Comments

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

---------

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle requested review from a team as code owners June 20, 2023 16:20
@ItalyPaleAle ItalyPaleAle mentioned this pull request Jun 20, 2023
17 tasks
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #6553 (8a78a9b) into release-1.11 (77ebace) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

@@               Coverage Diff                @@
##           release-1.11    #6553      +/-   ##
================================================
- Coverage         64.93%   64.89%   -0.04%     
================================================
  Files               192      192              
  Lines             19120    19125       +5     
================================================
- Hits              12415    12412       -3     
- Misses             5737     5745       +8     
  Partials            968      968              
Impacted Files Coverage Δ
pkg/actors/actors.go 66.79% <40.00%> (+0.25%) ⬆️

... and 3 files with indirect coverage changes

@artursouza artursouza merged commit a33da88 into dapr:release-1.11 Jun 20, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants