Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck: add "appid" support (update of #6278) #6642

Merged
merged 3 commits into from Jul 11, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

Re-do of #6278 opened by @alberthuang24

This PR is needed for dapr/components-contrib#2490

The original PR (#6278) was opened from a fork that didn't give maintainers write access, so we couldn't press "Update with master".

Re-do of dapr#6278

Co-Authored-By: AlbertHuang <r.albert.huang@gmail.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle requested review from a team as code owners July 10, 2023 17:21
@ItalyPaleAle ItalyPaleAle added the autoupdate DaprBot will keep the Pull Request up to date with master branch label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #6642 (c5f6693) into master (bfc3f1b) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #6642      +/-   ##
==========================================
- Coverage   65.86%   65.82%   -0.04%     
==========================================
  Files         197      197              
  Lines       19121    19127       +6     
==========================================
- Hits        12594    12591       -3     
- Misses       5527     5537      +10     
+ Partials     1000      999       -1     
Impacted Files Coverage Δ
pkg/http/api.go 78.33% <71.42%> (+0.09%) ⬆️

... and 4 files with indirect coverage changes

@artursouza artursouza merged commit 7386ac7 into dapr:master Jul 11, 2023
8 of 9 checks passed
@artursouza artursouza added this to the v1.12 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants