Pluggable component: Secret store #6733
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6733 +/- ##
==========================================
- Coverage 65.05% 64.90% -0.15%
==========================================
Files 231 232 +1
Lines 20595 20640 +45
==========================================
- Hits 13398 13397 -1
- Misses 6089 6126 +37
- Partials 1108 1117 +9
|
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
pravinpushkar
force-pushed
the
secretstore_pluggable_comp
branch
from
339dc99
to
7748354
Compare
pravinpushkar
changed the title
pravinpushkar
force-pushed
the
secretstore_pluggable_comp
branch
from
d5bc87e
to
1356a7a
Compare
| // GetSecretRequest is the message to get secret from secret store. | ||
| message GetSecretRequest { | ||
| // The name of secret key. | ||
| string key = 2; |
There was a problem hiding this comment.
Silly question, but should field numbering generally start at 1?
There was a problem hiding this comment.
it's not strictly necessary. The most important thing is that once you set a number, you never change it. https://protobuf.dev/programming-guides/proto3/#updating
There was a problem hiding this comment.
Yeah, I numbered it with 2 purposefully while trying to match the runtime/proto definition. I think, to make it consistent I will change with 1.
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
ItalyPaleAle
added
the
autoupdate
|
@artursouza @yaron2 @mukundansundar Can we merge this if it is being planned for 1.12 ? In that way I will try to get the sandbox-sdk PR also ready before 14th. |
Description
Issue reference
Please reference the issue this PR will close: #5635
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: