Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Error Handling/Codes][State Store] Adds ETAG MISMATCH Error Handling #6746

Closed

Conversation

robertojrojas
Copy link
Contributor

@robertojrojas robertojrojas commented Jul 28, 2023

Description

Adds ETAG MISMATCH Error Handling.

NOTE: This PR depends on KIT PR: dapr/kit#57

Issue reference

Please reference the issue this PR will close: #6472

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 39.28% and project coverage change: -0.47% ⚠️

Comparison is base (26e8352) 64.99% compared to head (319b418) 64.52%.

❗ Current head 319b418 differs from pull request most recent head bd46cf8. Consider uploading reports for the commit bd46cf8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6746      +/-   ##
==========================================
- Coverage   64.99%   64.52%   -0.47%     
==========================================
  Files         228      228              
  Lines       20823    20291     -532     
==========================================
- Hits        13533    13092     -441     
+ Misses       6163     6124      -39     
+ Partials     1127     1075      -52     
Files Changed Coverage Δ
pkg/config/configuration.go 58.16% <ø> (+0.37%) ⬆️
pkg/http/api.go 77.02% <22.72%> (-1.60%) ⬇️
pkg/grpc/api.go 73.32% <100.00%> (+0.41%) ⬆️
pkg/runtime/runtime.go 71.60% <100.00%> (-1.57%) ⬇️

... and 94 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Signed-off-by: Roberto Rojas <robertojrojas@gmail.com>
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add E2E test.

Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
Signed-off-by: robertojrojas <robertojrojas@gmail.com>
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale Issues and PRs without response label Nov 17, 2023
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 67 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and PRs without response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error Handling/Codes][State Store] Add ETAG MISMATCH Error Handling
3 participants