Fixes in control plane services CLI flags #6925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed flags that are deprecated and have no effect - Remove `tokenAudience` flag from Helm chart since it's now unused - Fixed description of some flags - Use constants for default trust anchors file path Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
added
the
autoupdate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6925 +/- ##
==========================================
- Coverage 65.10% 65.09% -0.02%
==========================================
Files 221 231 +10
Lines 20799 21049 +250
==========================================
+ Hits 13541 13701 +160
- Misses 6120 6207 +87
- Partials 1138 1141 +3
☔ View full report in Codecov by Sentry. |
…l-plane-cli Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
daixiang0
reviewed
Oct 7, 2023
|
Close this in favor of #7029 |
|
Per @mukundansundar this should be merged first |
|
@mukundansundar @daixiang0 is this ready to be merged? |
JoshVanL
previously approved these changes
Oct 31, 2023
…l-plane-cli Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
mukundansundar
added
breaking-change
mukundansundar
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenAudienceflag from Helm chart since it's now unused