Injector: Change daprd projected token audience to sentry SPIFFE ID #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7041 +/- ##
==========================================
+ Coverage 62.23% 62.26% +0.03%
==========================================
Files 240 240
Lines 22135 22137 +2
==========================================
+ Hits 13776 13784 +8
+ Misses 7209 7200 -9
- Partials 1150 1153 +3 ☔ View full report in Codecov by Sentry. |
|
/test-version-skew |
Dapr Version Skew test (control-plane-master - 1.12.0)Commit ref: 8f4b117 ✅ Version Skew tests passed |
Dapr Version Skew test (dapr-sidecar-master - 1.12.0)Commit ref: 8f4b117 ❌ Version Skew tests failedPlease check the logs for details on the error. |
JoshVanL
added
the
autoupdate
ItalyPaleAle
requested changes
Oct 21, 2023
JoshVanL
force-pushed
the
injector-patcher-daprd-sentry-audience
branch
from
cea11af
to
52cae4b
Compare
|
/test-version-skew |
Dapr Version Skew integration test (control-plane-master - 1.12.3)Commit ref: 52cae4b ✅ Version Skew tests passed |
This comment has been minimized.
This comment has been minimized.
Dapr Version Skew e2e test (control-plane-master - 1.12.3)Commit ref: 52cae4b ✅ Version Skew tests passed |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.3)Commit ref: 52cae4b ✅ Version Skew tests passed |
❌ Version Skew tests failedPlease check the logs for details on the error. |
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
injector-patcher-daprd-sentry-audience
branch
from
08125f6
to
6973095
Compare
Open
yaron2
approved these changes
Jan 19, 2024
whytem
pushed a commit
to whytem/dapr
that referenced
this pull request
Jan 22, 2024
…apr#7041) * Injector: Change daprd projected token audience to sentry SPIFFE ID Signed-off-by: joshvanl <me@joshvanl.dev> * Linting Signed-off-by: joshvanl <me@joshvanl.dev> * Change SidecarConfig to use string type for SentrySPIFFEID Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 24, 2024
…apr#7041) * Injector: Change daprd projected token audience to sentry SPIFFE ID Signed-off-by: joshvanl <me@joshvanl.dev> * Linting Signed-off-by: joshvanl <me@joshvanl.dev> * Change SidecarConfig to use string type for SentrySPIFFEID Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 25, 2024
…apr#7041) * Injector: Change daprd projected token audience to sentry SPIFFE ID Signed-off-by: joshvanl <me@joshvanl.dev> * Linting Signed-off-by: joshvanl <me@joshvanl.dev> * Change SidecarConfig to use string type for SentrySPIFFEID Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject the SPIFFE ID of sentry as the daprd sentry token audience over the legacy
dapr.io/sentry. More secure as it is more specific to the dapr cluster installation control plane trust domain and control plane namespace. The control plane components are already using the sentry SPIFFE ID of sentry as their identity token audience.The legacy
dapr.io/sentryaudience continues to be accepted by sentry for backwards compatibility.Part of #5756