Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change operator default port to 443. #7083

Merged
merged 26 commits into from Nov 24, 2023

Conversation

JoshVanL
Copy link
Contributor

The operator service should serve on 443 as this is the more proper TLS port over the current 80. The injector has been updated to now inject port 443 to sidecars. Port 80 is still being served for backwards compatibility, but should be removed in v1.14.

@JoshVanL JoshVanL requested review from a team as code owners October 23, 2023 09:33
@JoshVanL
Copy link
Contributor Author

/version-skew-test

@JoshVanL JoshVanL changed the title Change operator debug port to 443. Change operator default port to 443. Oct 23, 2023
@JoshVanL
Copy link
Contributor Author

/test-version-skew

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 23, 2023

Dapr Version Skew test (control-plane-master - 1.12.0)

🔗 Link to Action run

Commit ref: 51548c6

✅ Version Skew tests passed

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 23, 2023

Dapr Version Skew test (dapr-sidecar-master - 1.12.0)

🔗 Link to Action run

Commit ref: 51548c6

❌ Version Skew tests failed

Please check the logs for details on the error.

@JoshVanL JoshVanL added the autoupdate DaprBot will keep the Pull Request up to date with master branch label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9535b78) 64.53% compared to head (31c513d) 64.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7083      +/-   ##
==========================================
+ Coverage   64.53%   64.59%   +0.05%     
==========================================
  Files         225      225              
  Lines       21023    21023              
==========================================
+ Hits        13568    13580      +12     
+ Misses       6291     6282       -9     
+ Partials     1164     1161       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mukundansundar
mukundansundar previously approved these changes Nov 2, 2023
@mukundansundar
Copy link
Contributor

/test-version-skew

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 2, 2023

Dapr Version Skew test (control-plane-master - 1.12.0)

🔗 Link to Action run

Commit ref: 3e8e37d

✅ Version Skew tests passed

@mukundansundar mukundansundar added this to the v1.13 milestone Nov 2, 2023
@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 2, 2023

Dapr Version Skew test (dapr-sidecar-master - 1.12.0)

🔗 Link to Action run

Commit ref: 3e8e37d

❌ Version Skew tests failed

Please check the logs for details on the error.

@mukundansundar
Copy link
Contributor

The operator service should serve on 443 as this is the more proper TLS port over the current 80. The injector has been updated to now inject port 443 to sidecars. Port 80 is still being served for backwards compatibility, but should be removed in v1.14.

It should ideally be only removed in 1.15, 2 releases after deprecation.

Signed-off-by: joshvanl <me@joshvanl.dev>

The operator service should serve on 443 as this is the more proper TLS
port over the current 80. The injector has been updated to now inject
port 443 to sidecars. Port 80 is still being served for backwards
compatibility, but should be removed in v1.14.

Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL
Copy link
Contributor Author

@mukundansundar It was my understanding that this was not the case for non-API related control plane configuration options. For example we do not do this for removing CLI flags.

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0 daixiang0 merged commit de6339d into dapr:master Nov 24, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants