New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change operator default port to 443. #7083
Change operator default port to 443. #7083
Conversation
/version-skew-test |
/test-version-skew |
Dapr Version Skew test (control-plane-master - 1.12.0)Commit ref: 51548c6 ✅ Version Skew tests passed |
Dapr Version Skew test (dapr-sidecar-master - 1.12.0)Commit ref: 51548c6 ❌ Version Skew tests failedPlease check the logs for details on the error. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7083 +/- ##
==========================================
+ Coverage 64.53% 64.59% +0.05%
==========================================
Files 225 225
Lines 21023 21023
==========================================
+ Hits 13568 13580 +12
+ Misses 6291 6282 -9
+ Partials 1164 1161 -3 ☔ View full report in Codecov by Sentry. |
af8777d
to
d988ebd
Compare
/test-version-skew |
Dapr Version Skew test (control-plane-master - 1.12.0)Commit ref: 3e8e37d ✅ Version Skew tests passed |
Dapr Version Skew test (dapr-sidecar-master - 1.12.0)Commit ref: 3e8e37d ❌ Version Skew tests failedPlease check the logs for details on the error. |
It should ideally be only removed in 1.15, 2 releases after deprecation. |
Signed-off-by: joshvanl <me@joshvanl.dev> The operator service should serve on 443 as this is the more proper TLS port over the current 80. The injector has been updated to now inject port 443 to sidecars. Port 80 is still being served for backwards compatibility, but should be removed in v1.14. Signed-off-by: joshvanl <me@joshvanl.dev>
6afe7fa
to
5ed7d5a
Compare
@mukundansundar It was my understanding that this was not the case for non-API related control plane configuration options. For example we do not do this for removing CLI flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The operator service should serve on 443 as this is the more proper TLS port over the current 80. The injector has been updated to now inject port 443 to sidecars. Port 80 is still being served for backwards compatibility, but should be removed in v1.14.