Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing info to outbox requests #7198

Merged
merged 4 commits into from Nov 20, 2023
Merged

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Nov 15, 2023

Closes #7047.

Signed-off-by: yaron2 <schneider.yaron@live.com>
@yaron2 yaron2 requested review from a team as code owners November 15, 2023 19:27
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7432d61) 65.02% compared to head (d60b892) 64.99%.

Files Patch % Lines
pkg/grpc/api.go 0.00% 3 Missing ⚠️
pkg/http/api.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7198      +/-   ##
==========================================
- Coverage   65.02%   64.99%   -0.04%     
==========================================
  Files         221      221              
  Lines       20847    20857      +10     
==========================================
- Hits        13556    13555       -1     
- Misses       6146     6154       +8     
- Partials     1145     1148       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaron2 yaron2 merged commit 7e14aac into dapr:master Nov 20, 2023
19 of 22 checks passed
@yaron2 yaron2 deleted the outboxtracing-1 branch November 20, 2023 04:36
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outbox pattern Pub-Sub wrong cloudevent datacontenttype and missing OTEL info.
3 participants