Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Reflection service on gRPC server #7215

Merged
merged 3 commits into from Nov 20, 2023

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Nov 18, 2023

Description

Register reflection service on gRPC server, so that developers may debug more easily from the command line by running grpcurl commands. This addition saves developer time - they wont have to add this manually and rebuild dapr.

ex:

grpcurl -H 'dapr-app-id: sub' -d '{"pubsub_name":"fakeKafka", "topic":"fakeTopic"}' -plaintext localhost:57534 dapr.proto.runtime.v1.Dapr.PublishEvent
ERROR:
  Code: InvalidArgument
  Message: pubsub fakeKafka not found

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle requested review from a team as code owners November 18, 2023 06:04
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec20c83) 64.98% compared to head (9817fb0) 64.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7215      +/-   ##
==========================================
- Coverage   64.98%   64.95%   -0.04%     
==========================================
  Files         221      221              
  Lines       20864    20865       +1     
==========================================
- Hits        13559    13553       -6     
- Misses       6158     6162       +4     
- Partials     1147     1150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaron2 yaron2 merged commit 05affb7 into dapr:master Nov 20, 2023
18 of 22 checks passed
@artursouza artursouza added this to the v1.13 milestone Nov 21, 2023
@cicoyle cicoyle deleted the feat-add-server-reflection branch December 19, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants