New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Richer error codes model #7257
Merged
Merged
Richer error codes model #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elena-kolevska
force-pushed
the
error-codes
branch
from
December 4, 2023 23:19
b59805c
to
068a269
Compare
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
force-pushed
the
error-codes
branch
from
December 5, 2023 23:57
1668b03
to
2b942db
Compare
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
This was referenced Dec 11, 2023
Signed-off-by: Elena Kolevska <elena@kolevska.com> # Conflicts: # cmd/sentry/main.go # go.sum
This PR has a dependency on dapr/kit#77 ! |
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
force-pushed
the
error-codes
branch
from
December 11, 2023 17:39
f7006e5
to
12e8d6e
Compare
Signed-off-by: Elena Kolevska <elena@kolevska.com>
ItalyPaleAle
approved these changes
Jan 8, 2024
artursouza
approved these changes
Jan 9, 2024
/test-sdk-all |
Dapr SDK Go testCommit ref: e4926c5 ✅ Go SDK tests passed |
Dapr SDK Java testCommit ref: e4926c5 ❌ Java SDK tests failedPlease check the logs for details on the error. |
Dapr SDK Python testCommit ref: e4926c5 ✅ Python SDK tests passed |
Dapr SDK JS testCommit ref: e4926c5 ❌ JS SDK tests failedPlease check the logs for details on the error. |
5 tasks
This was referenced Jan 24, 2024
This was referenced Feb 2, 2024
5 tasks
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on the proposal for standardising Dapr error codes: https://github.com/dapr/proposals/blob/main/0009-BCIRS-error-handling-codes.md
It has a dependency on dapr/kit#77
Issue reference
#6068
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: