Adds actors healthz integration tests

[JoshVanL]

Adds integration tests for testing actor healthz behaviour when entities and or app healthz is defined.

Closes #7355

Mark actors as always healthy when there is no app channel or their have been
no actor entities (actor types) provided by the application config endpoint.
This is important for enabling actor related APIs such as workflows, which
don't rely on the application implementing actors itself.

Adds integration tests for actor healthz endpoints Most importantly, ensuring
that actors are marked as always healthy when the both the application healthz
endpoint is disabled, and the application reports no actor entities.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bea838) 62.32% compared to head (2ecee30) 62.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7394      +/-   ##
==========================================
+ Coverage   62.32%   62.34%   +0.02%     
==========================================
  Files         240      240              
  Lines       22154    22154              
==========================================
+ Hits        13807    13812       +5     
+ Misses       7190     7182       -8     
- Partials     1157     1160       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mukundansundar]

qq when there are no actor types and health check is disabled, why is a healthz endpoint needed and is being called?

[JoshVanL]

We are verifying this doesn't get called further down.

[mukundansundar]

@JoshVanL The IT seem to failing in the specific test that was written in this PR.

[JoshVanL]

Thanks @mukundansundar, it's clear this PR is causing some kind of unexpected side effect somewhere. I'm taking a look

[ItalyPaleAle]

This seems a bit off. I don't think we can do this because if the app has a HTTP app channel, ch will be non-nil.

Can you check pkg/actors/actors.go? Specifically, where a.checker is initialized:

https://github.com/JoshVanL/dapr/blob/a447ea75cd47e4c28256d6a5e4374dfadeb156ea/pkg/actors/actors.go#L278

Perhaps the way to fix this issue is to simply not initialize it if len(hat) == 0?

https://github.com/JoshVanL/dapr/blob/a447ea75cd47e4c28256d6a5e4374dfadeb156ea/pkg/actors/actors.go#L261

	if len(hat) > 0 {
		a.checker, err = a.getAppHealthChecker()
		if err != nil {
			return fmt.Errorf("actors: couldn't create health check: %w", err)
		}
	}

[JoshVanL]

I think it is OK because ch will be nil if entities is empty

dapr/pkg/actors/actors.go

Lines 317 to 319 in ecd3798

	if len(a.actorsConfig.Config.HostedActorTypes.ListActorTypes()) == 0 || a.appChannel == nil {
	return nil, nil
	}

[JoshVanL]

We should be covering this scenario in the noentities test.

https://github.com/dapr/dapr/pull/7394/files/a447ea75cd47e4c28256d6a5e4374dfadeb156ea#diff-104d2d64415550335dafcda3cb0730e5d866648f66f25ce74a40faffad722b58

[ItalyPaleAle]

Hold on, then if ch is already nil when entities is empty.... There's nothing we need to do in this PR? Was the issue already fixed? (And just needed tests?)

[ItalyPaleAle]

When we start placement, we already set appHealthy to true:

https://github.dev/JoshVanL/dapr/blob/a447ea75cd47e4c28256d6a5e4374dfadeb156ea/pkg/actors/placement/placement.go#L159

And if ch is nil, then this can never be set to false

(And if that weren't the case, workflow tests would have failed already sinced they don't implement /healthz)

[JoshVanL]

Without the code change made in this PR, the new test noentities will fail. i.e. actors will never become ready.

[ItalyPaleAle]

It works on my machine without this line. Please try it!

[artursouza]

@JoshVanL Please, double check this because we already have E2E to validate that sidecars that don't serve actors types can still invoke other actors.

[artursouza]

BTW, happy to take the integration test part of it.

[JoshVanL]

Done! I have just included the integration tests now. I have also updated the PR title and description.

[artursouza]

This is a regression because a sidecar that does not host actors can always use actors that are hosted by other instances. If this is the case, this is a hotfix.