Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow logs: Add prefix to completed message #7460

Merged
merged 1 commit into from Jan 29, 2024

Conversation

shivamkm07
Copy link
Contributor

Description

As per #7065 (comment), PR adds prefix strings to completed messages to help easier log searching.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@shivamkm07 shivamkm07 requested review from a team as code owners January 27, 2024 06:33
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c53fc16) 62.46% compared to head (dfb897c) 62.45%.

Files Patch % Lines
...runtime/wfengine/backends/actors/workflow_actor.go 0.00% 2 Missing ⚠️
...runtime/wfengine/backends/actors/activity_actor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7460      +/-   ##
==========================================
- Coverage   62.46%   62.45%   -0.02%     
==========================================
  Files         244      244              
  Lines       22132    22134       +2     
==========================================
- Hits        13825    13823       -2     
- Misses       7169     7173       +4     
  Partials     1138     1138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0 daixiang0 merged commit 83ad194 into dapr:master Jan 29, 2024
19 of 22 checks passed
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants