Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes minimum observed cluster api level. Fixes api level check for vnodes. Adds more unit and integration tests for placement service. #7462

Merged
merged 33 commits into from Feb 6, 2024

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Jan 29, 2024

Description

  • Fixes minimum observed cluster API level. Previously, the raft state store didn't consider the minAPIlevel received as an argument on placement cluster startup. It was only considered when new dapr instances were trying to connect. This PR corrects that. (by @artursouza )
  • Adds an integration test for the presence of vnodes in the placement table
  • Moves and cleans up some reused placement service integration test code to the testing framework.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska changed the title Adds int. tests for vnodes in placement table Adds integration tests for vnodes in placement table Jan 29, 2024
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (48be4cd) 62.20% compared to head (d0be920) 62.15%.
Report is 1 commits behind head on master.

❗ Current head d0be920 differs from pull request most recent head 6d5e2d3. Consider uploading reports for the commit 6d5e2d3 to get more accurate results

Files Patch % Lines
pkg/placement/raft/server.go 0.00% 4 Missing ⚠️
pkg/placement/hashing/consistent_hash.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7462      +/-   ##
==========================================
- Coverage   62.20%   62.15%   -0.05%     
==========================================
  Files         244      244              
  Lines       22285    22292       +7     
==========================================
- Hits        13862    13856       -6     
- Misses       7275     7286      +11     
- Partials     1148     1150       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska marked this pull request as ready for review January 29, 2024 23:44
@elena-kolevska elena-kolevska requested review from a team as code owners January 29, 2024 23:44
artursouza
artursouza previously approved these changes Jan 30, 2024
tests/integration/suite/placement/apilevel/no_max.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/apilevel/with_max.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/apilevel/with_min.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/table/vnodes.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/table/vnodes.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/table/vnodes.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/table/vnodes.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/table/vnodes.go Outdated Show resolved Hide resolved
elena-kolevska and others added 2 commits January 30, 2024 13:29
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska changed the title Adds integration tests for vnodes in placement table Adds more unit and integration tests for placement service. Fixes api level check. Jan 30, 2024
tests/integration/framework/process/placement/placement.go Outdated Show resolved Hide resolved
tests/integration/framework/process/placement/placement.go Outdated Show resolved Hide resolved
tests/integration/framework/process/placement/placement.go Outdated Show resolved Hide resolved
tests/integration/suite/placement/apilevel/with_max.go Outdated Show resolved Hide resolved
elena-kolevska and others added 5 commits January 30, 2024 15:16
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@artursouza artursouza mentioned this pull request Jan 30, 2024
elena-kolevska and others added 6 commits January 30, 2024 20:09
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@elena-kolevska elena-kolevska changed the title Adds more unit and integration tests for placement service. Fixes api level check. Fixes minimum observed cluster api level. Fixes api level check for vnodes. Adds more unit and integration tests for placement service. Jan 30, 2024
@artursouza artursouza added the autoupdate DaprBot will keep the Pull Request up to date with master branch label Jan 31, 2024
dapr-bot and others added 6 commits January 31, 2024 08:42
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska and others added 3 commits February 2, 2024 14:17
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
… is funny)

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@artursouza artursouza merged commit afe79bc into dapr:master Feb 6, 2024
29 checks passed
@elena-kolevska elena-kolevska deleted the placement-integration-tests branch February 6, 2024 11:01
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants