Actor Reminders: Default JSON serialization.

[JoshVanL]

To support downgrades to 1.12 from 1.13, this PR changes the reminder serialization storage format back to JSON by default. This means a 1.12 actor reminder client can read reminders written by 1.13 actors.

1.13 will continue to understand both JSON and protobuf. Protobuf serialization can be enabled with the ActorReminderStorageProtobuf feature gate. The actor "API Level" has been changed back to 10.

Adds test to ensure the default serialization is JSON.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05868fe) 62.14% compared to head (24c0586) 62.10%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.13    #7548      +/-   ##
================================================
- Coverage         62.14%   62.10%   -0.04%     
================================================
  Files               245      245              
  Lines             22389    22388       -1     
================================================
- Hits              13913    13905       -8     
+ Misses             7320     7319       -1     
- Partials           1156     1164       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ItalyPaleAle]

This need not be a configuration option, because no one (eventually) will want to have JSON.

To keep 1.13 to use JSON by default you simply just need to change this line:

dapr/charts/dapr/charts/dapr_placement/values.yaml

Line 26 in 518753d

maxActorApiLevel: -1

Change it to 10 and you're done :)

[JoshVanL]

@ItalyPaleAle Helm values currently aren't testable so is safer to do in code imo. It also doesn't cover placement in self-hosted mode.

[ItalyPaleAle]

@ItalyPaleAle Helm values currently aren't testable so is safer to do in code imo. It also doesn't cover placement in self-hosted mode.

This is not what was discussed in the call according to @mukundansundar ?

I really do not want a configuration option in the CRD as it will be there forever. The entire point of using API version in placement was so we could migrate more quickly, but adding a Configuration CRD option is a perennial choice.

For self-hosted we need to update the Docker Compose file examples. I would not be too concerned about self hosted as actor usage there is likely a tiny fraction.

[JoshVanL]

The protobuf serialization is opt-in through a feature gate rather than a dedicated config CRD field, and expected to be removed in 1.14 where protobuf is the only supported option.