Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curl example #2361

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Fix curl example #2361

merged 3 commits into from
Apr 20, 2022

Conversation

Taction
Copy link
Member

@Taction Taction commented Apr 13, 2022 •
edited
Loading

\ is missing for some curl examples.

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The request body is missing due to the absence of the \ character.

Issue reference

@Taction Taction requested review from a team as code owners April 13, 2022 06:36
msfussell
msfussell approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this

@Taction
Fix curl example
3cbcf52 
`\` is missing for some curl examples.

Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction
Merge branch 'v1.7' into patch-1
e2b8a32 
* v1.7:
  Fixed typo in security concept doc (dapr#2374)
  [state management] Update docs around transactional operations (dapr#2372)
  Fixes wrong working directory for dotnet state management sample (dapr#2359)

Signed-off-by: zhangchao <zchao9100@gmail.com>
@greenie-msft greenie-msft merged commit 0d3cdab into dapr:v1.7 Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taction @msfussell @greenie-msft