Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings commercetools #2363

Merged
merged 19 commits into from May 12, 2022
Merged

Bindings commercetools #2363

merged 19 commits into from May 12, 2022

Conversation

harrykimpel
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Adding documentation for the commercetools output binding.

Issue reference

#2351

@harrykimpel harrykimpel requested review from a team as code owners April 13, 2022 12:03
@harrykimpel
Adding commercetools binding
9def685 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Adding commercetools binding
58ec941 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Fixing GitHub Codespaces link validation issue
e030527 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Copy link
Contributor Author

the validate-links checker fails for the GitHub Codespaces overview page with a 403

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 19, 2022
@yaron2 yaron2 removed the stale label Apr 19, 2022
@yaron2 yaron2 added this to the 1.8 milestone Apr 19, 2022
berndverst
berndverst requested changes Apr 20, 2022
View reviewed changes
daprdocs/content/en/reference/components-reference/supported-bindings/commercetools.md Outdated
type: bindings.commercetools
version: v1
metadata:
- name: Region # required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing to your code PR all these meatadata fields must start with a lowercase character

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @harrykimpel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yaron2, will update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 26, 2022
@msfussell msfussell removed the stale label Apr 26, 2022
@harrykimpel
Updated docs for commercetools binding
70f4417 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Merge branch 'bindings-commercetools' of https://github.com/harrykimp…
87095cc 
…el/docs into bindings-commercetools
@harrykimpel
Updated docs for commercetools binding
e751b79 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@greenie-msft
Copy link
Collaborator

Hi @harrykimpel,

It looks like some additional files were checked-in unintentionally. Can you please revert those files (dccache ?)

Also, I noticed you added a link to a sample in your GitHub account. Are you open to submitting that to the official Samples repo in the Dapr org?

@harrykimpel
Updated docs for commercetools binding
41fa18a 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Copy link
Contributor Author

harrykimpel commented Apr 29, 2022 •
edited

Hi @harrykimpel,

It looks like some additional files were checked-in unintentionally. Can you please revert those files (dccache ?)

Also, I noticed you added a link to a sample in your GitHub account. Are you open to submitting that to the official Samples repo in the Dapr org?

@greenie-msft I removed the dccache file. I am also happy to submit the sample to the official sample repo. I wasn't sure whether this would belong there. are you referring to this repo https://github.com/dapr/samples or the quickstarts?

@msfussell
Copy link
Member

msfussell commented Apr 29, 2022 •
edited

I wasn't sure whether this would belong there. are you referring to this repo https://github.com/dapr/samples or the quickstarts?

Yes, submit to this Samples repo. The expectation on this repo is that the submitted chooses to keep the sample current and maintained. If these go very stale over time (i.e. Feature removed or does not compile) they get removed.

Please update this link in the doc- Sample app that leverages the commercetools binding with sample GraphQL query and then resubmit.

@harrykimpel
Copy link
Contributor Author

I wasn't sure whether this would belong there. are you referring to this repo https://github.com/dapr/samples or the quickstarts?

Yes, submit to this Samples repo. The expectation on this repo is that the submitted chooses to keep the sample current and maintained. If these go very stale over time (i.e. Feature removed or does not compile) they get removed.

Please update this link in the doc- Sample app that leverages the commercetools binding with sample GraphQL query and then resubmit.

@msfussell I added the samples app to the samples repo and updated the link in the docs

@harrykimpel
Updated docs for Azure SQL database
f289b0b 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Copy link
Contributor Author

Tried to update the link to the Azure SQL DB docs, but now I am getting a fail for a localized version

@github-actions
Copy link

github-actions bot commented May 6, 2022

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label May 6, 2022
@msfussell msfussell removed the stale label May 6, 2022
@msfussell
Copy link
Member

@harrykimpel - See comment on the Sample repo PR here dapr/samples#106

@harrykimpel
Updating commercetools docs
8849023 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@harrykimpel
Merge branch 'bindings-commercetools' of https://github.com/harrykimp…
8dd7dcd 
…el/docs into bindings-commercetools
@harrykimpel
Copy link
Contributor Author

@harrykimpel - See comment on the Sample repo PR here dapr/samples#106

@msfussell done

harrykimpel and others added 2 commits May 9, 2022 09:07
@harrykimpel
Updating commercetools docs
2c4b721 
Signed-off-by: Harry Kimpel <harrykimpel@hotmail.com>
@msfussell
Merge branch 'v1.8' into bindings-commercetools
80f1aa0
msfussell
msfussell approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@msfussell
Copy link
Member

@harrykimpel - Just found the link issue above. PTAL?

harrykimpel and others added 2 commits May 10, 2022 10:25
@harrykimpel @msfussell
Update daprdocs/content/en/reference/components-reference/supported-b…
acedba5 
…indings/commercetools.md


yes, fine with me

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@msfussell
Merge branch 'v1.8' into bindings-commercetools
f355e17
@msfussell
Copy link
Member

Thanks for the amazing contribution!!

@msfussell msfussell merged commit e467120 into dapr:v1.8 May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

@yaron2 yaron2 yaron2 left review comments

@berndverst berndverst berndverst requested changes

Assignees

@harrykimpel harrykimpel

Labels
area/components
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harrykimpel @greenie-msft @msfussell @berndverst @yaron2