Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace dapr.io/placement-addresses with dapr.io/placement-host-address #2427

Merged
merged 1 commit into from May 6, 2022
Merged

replace dapr.io/placement-addresses with dapr.io/placement-host-address #2427

merged 1 commit into from May 6, 2022

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented May 6, 2022

Signed-off-by: crazyhzm crazyhzm@apache.org

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Within this PR dapr/dapr#4094, dapr.io/placement-addresses has been replaced with dapr.io/placement-host-address,

Issue reference

Follow #2358

@CrazyHZM CrazyHZM requested review from a team as code owners May 6, 2022 03:55
msfussell
msfussell approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 9176573 into dapr:v1.8 May 6, 2022
@yaron2 yaron2 added this to the 1.8 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell msfussell approved these changes

Assignees

@CrazyHZM CrazyHZM

Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CrazyHZM @msfussell @yaron2