Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wasm http middleware #2520

Merged
merged 17 commits into from
Jun 24, 2022
Merged

add wasm http middleware #2520

merged 17 commits into from
Jun 24, 2022

Conversation

daixiang0
Copy link
Member

Signed-off-by: Loong Dai loong.dai@intel.com

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

@daixiang0
add wasm http middleware
5aa0100 
Signed-off-by: Loong Dai <loong.dai@intel.com>
@daixiang0 daixiang0 requested review from a team as code owners June 13, 2022 02:49
@daixiang0
Copy link
Member Author

related to dapr/components-contrib#1747

@daixiang0
Copy link
Member Author

for dapr/dapr#4765

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jun 21, 2022
@msfussell msfussell removed the stale label Jun 21, 2022
@msfussell
Copy link
Member

@daixiang0 - Any update here?

@msfussell
Copy link
Member

@daixiang0 - Pinging again? We are in endgame and need to close this issue. Can you

  1. Review my comments
  2. Check the Wasm Hello world example into the Dapr/Samples repo?

@daixiang0
Copy link
Member Author

@msfussell sorry for the slow response, I am busy this week and will do this next week.

yaron2 and others added 11 commits June 24, 2022 09:12
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
c1c276a 
…iddleware/_index.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
8735ff4 
…iddleware/middleware-wasm.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
56a3900 
…iddleware/middleware-wasm.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
fbd5452 
…iddleware/middleware-wasm.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
366c0e7 
…iddleware/middleware-wasm.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2
Merge branch 'v1.8' into wasm
5651f50
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
f94d116 
…iddleware/middleware-wasm.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2 @msfussell
Update daprdocs/content/en/reference/components-reference/supported-m…
c1d5fd3 
…iddleware/middleware-wasm.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
@yaron2
Update middleware-wasm.md
9062187
@yaron2
Update middleware-wasm.md
5b619cf
@yaron2
Update middleware-wasm.md
97ba2b1
msfussell
msfussell reviewed Jun 24, 2022
View reviewed changes
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md Outdated

| Field | Details | Example |
|-------|---------|---------|
| path | The path to the WASM binary | "./hello.wasm" |
Copy link
Member

@msfussell msfussell Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally (not K8s) this is relative to where the configuration file is correct? Probably should say so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

msfussell
msfussell reviewed Jun 24, 2022
View reviewed changes
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md Outdated
| Field | Details | Example |
|-------|---------|---------|
| path | The path to the WASM binary | "./hello.wasm" |
| runtime | The WASM runtime of your WASM binary. Only`wazero` is supported | "wazero" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a URL to wazero runtime so that this is clear

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

msfussell
msfussell approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit d3dfc9a into dapr:v1.8 Jun 24, 2022
@daixiang0 daixiang0 deleted the wasm branch June 27, 2022 01:55
@daixiang0
Copy link
Member Author

@msfussell @yaron2 thanks for your help! I will add example later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 left review comments

@msfussell msfussell msfussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daixiang0 @msfussell @yaron2