Workflow terminate/purge: remove non_recursive query option
#4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates from PR dapr/dapr#7498 Signed-off-by: joshvanl <me@joshvanl.dev>
msfussell
added
the
waiting-on-code-pr
|
@JoshVanL - Looks great. Set to waiting on Code PR before merging. |
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
changed the title
non_recursive query to recursivenon_recursive query option
|
@msfussell please note the PR is updated to now remove the query completely after discussion on dapr/dapr#7498 |
For the recursive purge, we decide to remove the setting altogether, it that it always does this? Just making sure I understand this correctly. This statement "Removes this option so that recursive is always enabled with no API field exposing the option." |
shivamkm07
approved these changes
Feb 7, 2024
|
@msfussell correct, the option has been completely removed, and workflow deletion will always be done recursively. This option can be added back in future if we decide it is needed. |
hhunter-ms
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from PR dapr/dapr#7498