Adding in new test for parallel raise events in workflow #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1155 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 171 171
Lines 5758 5758
Branches 626 626
=======================================
Hits 3825 3825
Misses 1784 1784
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
halspang
approved these changes
Oct 6, 2023
halspang
pushed a commit
to halspang/dotnet-sdk
that referenced
this pull request
Oct 6, 2023
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
halspang
pushed a commit
to halspang/dotnet-sdk
that referenced
this pull request
Oct 6, 2023
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
halspang
pushed a commit
to halspang/dotnet-sdk
that referenced
this pull request
Oct 6, 2023
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Hal Spang <halspang@microsoft.com>
halspang
added a commit
that referenced
this pull request
Oct 6, 2023
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Hal Spang <halspang@microsoft.com> Co-authored-by: Ryan Lettieri <67934986+RyanLettieri@users.noreply.github.com>
IliasP91
pushed a commit
to IliasP91/dotnet-sdk
that referenced
this pull request
Oct 13, 2023
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
IliasP91
pushed a commit
to IliasP91/dotnet-sdk
that referenced
this pull request
Oct 13, 2023
* Adding in new test for parallel raise events in workflow Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, raising multiple events of the same name in parallel in workflow led to a series of events being incomplete. A change was made to durable task framework in the .NET SDK to fix this issue. This PR adds in a test to ensure that the fix works in this SDK as well.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[1129]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: