Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actor reminder example. #1179

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

philliphoff
Copy link
Contributor

Description

Updates the actor reminder example to resolve an unexpected exception. The actor was attempting to directly return an IActorReminder instance but the underlying type was not intended to be used outside of the actor and was not designed to be serialized. Instead, its properties are now copied to a separate type which is returned to the caller. A couple of other changes were made to the client project to correct assumptions about return types.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1177

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Phillip Hoff <phillip@orst.edu>
@philliphoff philliphoff requested review from a team as code owners October 26, 2023 18:18
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02ab25e) 66.42% compared to head (7e9d5e7) 66.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files         171      171           
  Lines        5758     5758           
  Branches      626      626           
=======================================
  Hits         3825     3825           
  Misses       1784     1784           
  Partials      149      149           
Flag Coverage Δ
net6 66.42% <ø> (ø)
net7 66.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@halspang halspang merged commit 2332388 into dapr:master Nov 13, 2023
10 checks passed
@philliphoff philliphoff deleted the philliphoff-get-reminder-fix branch November 17, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception running Actor example: Type 'Dapr.Actors.Runtime.ActorReminder' cannot be serialized.
2 participants