-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples - Add k8s deployment yaml to DemoActor sample #1308
Merged
philliphoff
merged 13 commits into
dapr:master
from
m3nax:add-dockerfile-to-demoactor-example
Jun 26, 2024
Merged
Samples - Add k8s deployment yaml to DemoActor sample #1308
philliphoff
merged 13 commits into
dapr:master
from
m3nax:add-dockerfile-to-demoactor-example
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
614b4b2
to
8b7ebcf
Compare
philliphoff
reviewed
Jun 25, 2024
philliphoff
reviewed
Jun 25, 2024
philliphoff
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks ok to me, but would like to keep the repo out of the container generation business as much as possible.
philliphoff
reviewed
Jun 25, 2024
8a01f03
to
08c0ff4
Compare
@philliphoff DCO is really annoying |
@m3nax Yes, quite. |
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
* Added overload for DaprClient DI registration allowing the consumer to easily use values from injected services (e.g. IConfiguration). Signed-off-by: Whit Waldo <whit.waldo@innovian.net> * Added supporting unit test Signed-off-by: Whit Waldo <whit.waldo@innovian.net> --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net> Co-authored-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
* Update protos and related use for Dapr 1.13. (dapr#1236) * Update protos and related use. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update Dapr runtime version. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Init properties. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update artifact action versions. (dapr#1240) Signed-off-by: Phillip Hoff <phillip@orst.edu> * Make recursive true as default (dapr#1243) Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Fix for secret key transformation in multi-value scenarios (dapr#1274) * Add repro test. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Fix for secret key transformation in multi-value scenarios. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update Dapr version numbers used during testing. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
409439b
to
1adc956
Compare
@philliphoff All check passed, DCO signed |
philliphoff
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Dockerfile to build DemoActor example and a manifest to deploy it inside k8s cluster.
Issue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: