Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples - Add k8s deployment yaml to DemoActor sample #1308

Merged
merged 13 commits into from
Jun 26, 2024

Conversation

m3nax
Copy link
Contributor

@m3nax m3nax commented Jun 17, 2024

Description

Add Dockerfile to build DemoActor example and a manifest to deploy it inside k8s cluster.

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@m3nax m3nax force-pushed the add-dockerfile-to-demoactor-example branch from 614b4b2 to 8b7ebcf Compare June 24, 2024 18:11
@m3nax m3nax marked this pull request as ready for review June 24, 2024 18:15
@m3nax m3nax requested review from a team as code owners June 24, 2024 18:15
@m3nax
Copy link
Contributor Author

m3nax commented Jun 24, 2024

image

I cannot see which test failed because I don't have access to the organization.

Copy link
Contributor

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks ok to me, but would like to keep the repo out of the container generation business as much as possible.

@philliphoff philliphoff added this to the v1.14 milestone Jun 25, 2024
@m3nax m3nax requested a review from philliphoff June 25, 2024 19:59
@m3nax m3nax force-pushed the add-dockerfile-to-demoactor-example branch from 8a01f03 to 08c0ff4 Compare June 25, 2024 21:59
@m3nax
Copy link
Contributor Author

m3nax commented Jun 25, 2024

@philliphoff DCO is really annoying

@philliphoff
Copy link
Contributor

DCO is really annoying

@m3nax Yes, quite.

m3nax and others added 12 commits June 26, 2024 05:56
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
* Added overload for DaprClient DI registration allowing the consumer to easily use values from injected services (e.g. IConfiguration).

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

* Added supporting unit test

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>

---------

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Phillip Hoff <phillip@orst.edu>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
* Update protos and related use for Dapr 1.13. (dapr#1236)

* Update protos and related use.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Update Dapr runtime version.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Init properties.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

---------

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Update artifact action versions. (dapr#1240)

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Make recursive true as default (dapr#1243)

Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>

* Fix for secret key transformation in multi-value scenarios (dapr#1274)

* Add repro test.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Fix for secret key transformation in multi-value scenarios.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

---------

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Update Dapr version numbers used during testing.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

---------

Signed-off-by: Phillip Hoff <phillip@orst.edu>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Co-authored-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
@m3nax m3nax force-pushed the add-dockerfile-to-demoactor-example branch from 409439b to 1adc956 Compare June 26, 2024 03:57
@m3nax m3nax closed this Jun 26, 2024
@m3nax m3nax reopened this Jun 26, 2024
@m3nax m3nax requested a review from philliphoff June 26, 2024 04:05
@m3nax m3nax closed this Jun 26, 2024
@m3nax m3nax reopened this Jun 26, 2024
@m3nax m3nax closed this Jun 26, 2024
@m3nax m3nax reopened this Jun 26, 2024
@m3nax
Copy link
Contributor Author

m3nax commented Jun 26, 2024

@philliphoff All check passed, DCO signed

@philliphoff philliphoff merged commit 8496253 into dapr:master Jun 26, 2024
26 of 30 checks passed
@m3nax m3nax deleted the add-dockerfile-to-demoactor-example branch June 26, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants