Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused stuff #1309

Closed

Conversation

RafaelJCamara
Copy link

Description

Removed unused references, and variables.
Simplified namespaces.
Adjusts in tests, because their build was failing because of not awaiting async method calls.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@RafaelJCamara RafaelJCamara requested review from a team as code owners June 19, 2024 10:14
@@ -15,7 +15,7 @@ namespace Dapr.Actors
{
using System;
using System.Runtime.Serialization;
using Dapr.Actors.Client;
using Client;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a fan of abbreviating namespaces in this way, even if it's technically allowed. For Dapr.Client, in particular, there's just too many other "client" types and I'd prefer to be explicit. (If anything, I would propose moving using statements to be above the namespace declaration and use the namespace <ns>; form rather than namespace <ns> { /* ... */ }. That's a significant refactor, however, so it's only been done on a piecemeal basis when working within individual files.)

Copy link
Contributor

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the effort to cleanup the codebase--and there's plenty to do there--this is a hefty PR. While the changes all appear individually trivial, it would be easy to miss a change that might have unintended consequences. I would prefer to split this up into several PRs that each address a particular thing (e.g. removal of unused using statements, another that cleaned up unused fields/values, etc.) which will make the changes easier to review.

@RafaelJCamara
Copy link
Author

While I appreciate the effort to cleanup the codebase--and there's plenty to do there--this is a hefty PR. While the changes all appear individually trivial, it would be easy to miss a change that might have unintended consequences. I would prefer to split this up into several PRs that each address a particular thing (e.g. removal of unused using statements, another that cleaned up unused fields/values, etc.) which will make the changes easier to review.

I'll split that in multiple PRs! Thank you so much for the feedback!

@RafaelJCamara RafaelJCamara deleted the removing_unused_things branch June 22, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants