Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating get started and samples readme #70

Merged
merged 10 commits into from
Oct 7, 2019
Merged

Updating get started and samples readme #70

merged 10 commits into from
Oct 7, 2019

Conversation

amanbha
Copy link
Contributor

@amanbha amanbha commented Oct 5, 2019

No description provided.

@davidfowl
Copy link

The instructions have this:

dotnet add package Microsoft.Dapr.Actors -v 0.3.0-preview01 -s ~/tmp/nugets/

Remove the specific version and -s ~/tmp/nugets/. It's better if you let people configure the feed or you'll be forever updating the version number.

shalabhms
shalabhms previously approved these changes Oct 5, 2019
View reviewed changes
@amanbha amanbha changed the title Updating actors get started. Updating get started and samples readme Oct 6, 2019
@amanbha amanbha requested a review from rynowak October 6, 2019 03:40
youngbupark
youngbupark suggested changes Oct 6, 2019
View reviewed changes
Copy link

@youngbupark youngbupark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to double check if we use actions name in code base:)

docs/get-started-dapr-actor.md Show resolved Hide resolved
@amanbha amanbha mentioned this pull request Oct 7, 2019
Closed
@amanbha amanbha merged commit a0e1b39 into master Oct 7, 2019
@amanbha amanbha deleted the update_actorsdoc branch October 7, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@youngbupark youngbupark youngbupark approved these changes

@shalabhms shalabhms shalabhms left review comments

@rynowak rynowak Awaiting requested review from rynowak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amanbha @davidfowl @youngbupark @shalabhms