Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gRPC to 1.64.0 #570

Open
mikeee opened this issue May 30, 2024 · 0 comments
Open

Upgrade gRPC to 1.64.0 #570

mikeee opened this issue May 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mikeee
Copy link
Member

mikeee commented May 30, 2024

Describe the bug

A client refactor is needed when upgrading to gRPC 1.64.0
The client shouldn't block prior to making RPC calls and instead, use timeouts on the calls rather than the client connection itself.

client/client.go:328:3        staticcheck  SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x.
client/client.go:340:15       staticcheck  SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.
client/client.go:376:15       staticcheck  SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x.
client/client_test.go:155:12  staticcheck  SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.
client/wait_test.go:106:15    staticcheck  SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.

To Reproduce

use make lint to describe the deprecated issues and reference docs https://pkg.go.dev/google.golang.org/grpc#DialContext

Expected behavior

@mikeee mikeee added the bug Something isn't working label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant