add Unix domain socket support #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daixiang0
force-pushed
the
uds
branch
2 times, most recently
from
afa1d83
to
98774e2
Compare
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 63.14% 63.72% +0.58%
==========================================
Files 23 23
Lines 1305 1315 +10
==========================================
+ Hits 824 838 +14
+ Misses 405 402 -3
+ Partials 76 75 -1
Continue to review full report at Codecov.
|
daixiang0
force-pushed
the
uds
branch
3 times, most recently
from
9d515fc
to
6c47b09
Compare
Signed-off-by: Long <long0dai@foxmail.com>
Signed-off-by: Long <long.dai@intel.com>
|
@artursouza @yaron2 please review. |
artursouza
requested changes
Nov 10, 2021
| First, the app instantiates Dapr client: | ||
|
|
||
| ```go | ||
| client, err := dapr.NewClientWithSocket(socket) |
There was a problem hiding this comment.
Why duplicating the whole example just for socket connection?
There was a problem hiding this comment.
Changes are here:
6d5
< "os"
16c15
< daprPort = "3500"
---
> socket = "/tmp/dapr-order-app-grpc.socket"
19,26d17
< var port string
<
< func init() {
< if port = os.Getenv("DAPR_GRPC_PORT"); len(port) == 0 {
< port = daprPort
< }
< }
<
36c27
< client, err := dapr.NewClientWithPort(port)
---
> client, err := dapr.NewClientWithSocket(socket)
Use patch in example is not common I think.
|
@yaron2 ping |
yaron2
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #198
Signed-off-by: Long long0dai@foxmail.com