Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement a more resilient validation workflow #574

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jun 14, 2024

Description

The validation workflow in its current state does not work with custom references provided for the cli or runtime on workflow_dispatches.

This validation workflow has been updated to build a dapr docker image and use this instead of overriding services.

Issue reference

Please reference the issue this PR will close: #N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mikeee mikeee requested review from a team as code owners June 14, 2024 10:36
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.04%. Comparing base (27248ba) to head (01e1668).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   58.04%   58.04%           
=======================================
  Files          55       55           
  Lines        3568     3568           
=======================================
  Hits         2071     2071           
  Misses       1375     1375           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee mikeee force-pushed the ci-validation branch 4 times, most recently from 8f17e9e to 5bc8fc0 Compare June 14, 2024 11:24
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee force-pushed the ci-validation branch 4 times, most recently from 8077cad to f0415e7 Compare June 14, 2024 12:28
@mikeee mikeee marked this pull request as draft June 14, 2024 13:23
@mikeee mikeee force-pushed the ci-validation branch 5 times, most recently from f201241 to 2006eca Compare June 14, 2024 23:35
@mikeee
Copy link
Member Author

mikeee commented Jun 20, 2024

Successful run against cli and dapr master branches: https://github.com/dapr/go-sdk/actions/runs/9529415535

Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee marked this pull request as ready for review June 20, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant