Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make workflow client struct public #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

famarting
Copy link
Contributor

Description

Make workflow client struct public, so it can be referenced and typed and passed as a variable in other applications.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@famarting famarting requested review from a team as code owners June 19, 2024 10:24
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (27248ba) to head (4c7f25d).
Report is 11 commits behind head on main.

Files Patch % Lines
workflow/client.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   58.04%   58.04%           
=======================================
  Files          55       55           
  Lines        3568     3568           
=======================================
  Hits         2071     2071           
  Misses       1375     1375           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee mikeee added this to the v1.11 milestone Jun 19, 2024
@mikeee mikeee added the enhancement New feature or request label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants