Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check for existing healthz route to avoid overwriting user cu… #580

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

antontroshin
Copy link
Contributor

Description

Added a check for existing healthz route to avoid overwriting user custom handler

Issue reference

#579

Please reference the issue this PR will close: #579

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…stom handler

Signed-off-by: Anton Troshin <anton@diagrid.io>
@antontroshin antontroshin requested review from a team as code owners June 20, 2024 19:22
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.17%. Comparing base (27248ba) to head (a2b727c).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   58.04%   58.17%   +0.12%     
==========================================
  Files          55       55              
  Lines        3568     3574       +6     
==========================================
+ Hits         2071     2079       +8     
+ Misses       1375     1374       -1     
+ Partials      122      121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaron2 yaron2 merged commit dd35c21 into dapr:main Jun 20, 2024
19 checks passed
@antontroshin antontroshin deleted the custom-health-check-fix branch June 20, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go SDK healthz override
3 participants