Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lock): Add HTTP support for Distributed Locking #414

Closed
nad-au opened this issue Oct 18, 2022 · 6 comments · Fixed by #478
Closed

feat(lock): Add HTTP support for Distributed Locking #414

nad-au opened this issue Oct 18, 2022 · 6 comments · Fixed by #478
Assignees
Labels
enhancement New feature or request pinned

Comments

@nad-au
Copy link

nad-au commented Oct 18, 2022

I'm using SDK v2.4.2 and latest dapr self-host docker images. When I call the lock & configuration APIs such as lock.tryLock or configuration.get it returns HTTP is currently not supported.

I've created components as per docs all using Redis. State APIs, pubsub etc. all working fine. I am using Dapr with HTTP from a NestJs app.

@shubham1172 shubham1172 added the enhancement New feature or request label Oct 18, 2022
@nad-au
Copy link
Author

nad-au commented Oct 18, 2022

There is a Note here https://docs.dapr.io/developing-applications/building-blocks/configuration/howto-manage-configuration/ which states that only supports gRPC. There isn't a similar note in the Distributed Locks documentation. Perhaps its worth annotating the APIs to make it clear which protocols are supported. Does seem rather strange though that configuration supports only gRPC when it is similar to state store.

@shubham1172
Copy link
Member

shubham1172 commented Oct 18, 2022

Yes, the configuration API only supports gRPC but the Distributed Lock has HTTP support - https://v1-10.docs.dapr.io/reference/api/distributed_lock_api/ - have updated the issue title to clarify the intent of this issue.

Perhaps its worth annotating the APIs to make it clear which protocols are supported. Does seem rather strange though that configuration supports only gRPC when it is similar to state store.

It is expected to get HTTP support once it moves to stable from alpha. Also there is an open issue which will be useful to document it more clearly dapr/docs#2526

@shubham1172 shubham1172 changed the title HTTP is currently not supported error when using lock & configuration APIs feat(lock): Add HTTP support for Distributed Locking Oct 18, 2022
@dapr-bot
Copy link
Collaborator

dapr-bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Jan 8, 2023
@XavierGeerinck
Copy link
Contributor

/keep-alive

@dapr-bot dapr-bot removed the stale label Jan 8, 2023
@dapr-bot
Copy link
Collaborator

dapr-bot commented Mar 9, 2023

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Mar 9, 2023
@shubham1172
Copy link
Member

/keep-alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants