Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate createHTTPMetadataQueryParam in favor of createHTTPQueryParam #479

Closed
XavierGeerinck opened this issue Apr 25, 2023 · 2 comments · Fixed by #480
Closed
Assignees

Comments

@XavierGeerinck
Copy link
Contributor

We are deprecating

export function createHTTPMetadataQueryParam(metadata: KeyValueType = {}): string {

In favor of

export function createHTTPQueryParam(...params: { data?: KeyValueType; type?: "metadata" }[]): string {

Which was introduced by

#476

@SoTrx
Copy link
Contributor

SoTrx commented Apr 25, 2023

Well, I might as well clean up my own mess, can I take that ?

@XavierGeerinck
Copy link
Contributor Author

Yes you can! 🤩 thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants