Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DAPR_HTTP_ENDPOINT and/or DAPR_GRPC_ENDPOINT #502

Closed
artursouza opened this issue Jun 12, 2023 · 2 comments · Fixed by #519
Closed

Support DAPR_HTTP_ENDPOINT and/or DAPR_GRPC_ENDPOINT #502

artursouza opened this issue Jun 12, 2023 · 2 comments · Fixed by #519
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@artursouza
Copy link
Member

Describe the proposal

Allow consistent way to configure endpoint for Dapr's sidecar, while enabling remote sidecar configuration.

Child of dapr/dapr#6035

SDK should parse these in a consistent way, so operators have a consistent environment variable to set for Dapr apps. Right now, each SDK has their own way of configuring the endpoint for Dapr's sidecar.

If SDK allows gRPC communication from SDK to sidecar, then DAPR_GRPC_ENDPOINT must be supported.
If SDK allows HTTP communication from SDK to sidecar, then DAPR_HTTP_ENDPOINT must be supported.
DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT and not exclusive, meaning it is acceptable to support both, like in the Java SDK, if the SDK supports both protocols.
Also, companies might decide to offer different endpoints per protocol, so there is not an unique environment variable for both.

@shubham1172
Copy link
Member

Copying from the parent issue"

FYI the JavaScript SDK already has this configuration embedded into the API. For instance, one could do

const daprHost = "127.0.0.1"; // Dapr Sidecar Host, could also be https://example.com
const daprPort = "3500"; // Dapr Sidecar Port of this Example Server
// HTTP Example
const client = new DaprClient({ daprHost, daprPort });

Having extra environment variables is not required, but it can be there and the API options can take precedence over env var.

These new environment variables can exist in JS-SDK, and daprHost/daprPort will take precedence.

@shubham1172 shubham1172 added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2023
@elena-kolevska
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants