Adds support for Unsubscribe Configuration #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 89.58% 89.40% -0.19%
==========================================
Files 55 55
Lines 2486 2500 +14
==========================================
+ Hits 2227 2235 +8
- Misses 259 265 +6
Continue to review full report at Codecov.
|
Signed-off-by: GitHub <noreply@github.com>
artursouza
reviewed
Jun 23, 2022
| @@ -671,23 +672,32 @@ def __init__(self): | |||
| def get_items(self): | |||
| return self.items | |||
|
|
|||
| def watch_configuration(self, stub, store_name, keys, config_metadata): | |||
| def watch_configuration(self, stub: api_service_v1.DaprStub, store_name: str, | |||
There was a problem hiding this comment.
In the Java SDK, we have created a new interface to keep Alpha APIs separate. Making it clear that they can break.
artursouza
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for unsubscribe configuration
Issue reference
Fixes #414
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: